Feature/audit strategy log

[andrestejerina97]

ref: https://app.clickup.com/t/86b6r27rt

[Copilot]

Pull Request Overview

This PR introduces an OpenTelemetry (OTLP) audit strategy for logging entity changes as telemetry data instead of traditional database records. The implementation provides a new audit mechanism that can send audit logs to external observability systems like Elasticsearch through OpenTelemetry collectors.

• Implements OTLP-based audit strategy using OpenTelemetry logging
• Adds comprehensive test coverage for the new audit functionality
• Configures OpenTelemetry collector to export logs to Elasticsearch

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
app/Audit/Interfaces/IAuditStrategy.php	Defines contract for audit strategy implementations
app/Audit/AuditLogOtlpStrategy.php	Main OTLP audit strategy implementation with telemetry logging
app/Audit/AuditEventListener.php	Updated to support strategy selection between DB and OTLP auditing
tests/OpenTelemetry/AuditOtlpStrategyTest.php	Comprehensive tests for OTLP audit strategy with real entities
tests/OpenTelemetry/AuditEventTypesTest.php	Tests for different audit event types (create, update, delete)
tests/OpenTelemetry/OpenTelemetryTestCase.php	Adds OTEL_LOGS_EXPORTER environment variable for test isolation
docker-compose/opentelemetry/otel-collector-config.yaml	Configures Elasticsearch as logs exporter
.env.example	Adds configuration for Elasticsearch index name

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Consider adding null checks for method return values to prevent null values in audit data, which could cause issues downstream in log processing systems.

Suggested change

	$data['id'] = $entity->getId();
	}
	if (method_exists($entity, 'getTitle')) {
	$data['title'] = $entity->getTitle();
	}
	if (method_exists($entity, 'getName')) {
	$data['name'] = $entity->getName();
	}
	if (method_exists($entity, 'getSlug')) {
	$data['slug'] = $entity->getSlug();
	$id = $entity->getId();
	if ($id !== null) {
	$data['id'] = $id;
	}
	}
	if (method_exists($entity, 'getTitle')) {
	$title = $entity->getTitle();
	if ($title !== null) {
	$data['title'] = $title;
	}
	}
	if (method_exists($entity, 'getName')) {
	$name = $entity->getName();
	if ($name !== null) {
	$data['name'] = $name;
	}
	}
	if (method_exists($entity, 'getSlug')) {
	$slug = $entity->getSlug();
	if ($slug !== null) {
	$data['slug'] = $slug;
	}

[andrestejerina97]

Solved

[Copilot]

Parameter should have a type hint for better type safety and IDE support. Consider adding the specific entity type or a base interface.

Suggested change

	private function createSummitEventChangeSet($summitEvent): array
	private function createSummitEventChangeSet(object $summitEvent): array

[romanetar]

LGTM

[smarcet]

@andrestejerina97 please review comments

[smarcet]

please review this logic

if (!env('OTEL_SERVICE_ENABLED', false)) return new AuditLogStrategy($em);
   try {
                return App::make(AuditLogOtlpStrategy::class);
            } catch (\Exception $e) {
                Log::warning('Failed to create OTLP audit strategy, falling back to database', [
                    'error' => $e->getMessage()
                ]);
                // Fall through to database strategy
            }
     return null       

[andrestejerina97]

I adjusted the logic to use OTLP, and if that fails, it uses AuditLog DB

[smarcet]

@andrestejerina97 please review comments

[Copilot]

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The env() function should not be used directly in classes as it bypasses Laravel's configuration caching. Use config() instead and define the configuration in a config file.

Suggested change

	$this->enabled = env('OTEL_SERVICE_ENABLED', false);
	$this->elasticIndex = env('OTEL_AUDIT_ELASTICSEARCH_INDEX', 'logs-audit');
	$this->enabled = config('opentelemetry.service_enabled', false);
	$this->elasticIndex = config('opentelemetry.audit_elasticsearch_index', 'logs-audit');

[Copilot]

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[smarcet]

LGTM