Don't require yaml for configuration#22
Open
erik-megarad wants to merge 1 commit intoOneHQ:masterfrom
erik-megarad:master
Open
Don't require yaml for configuration#22erik-megarad wants to merge 1 commit intoOneHQ:masterfrom erik-megarad:master
erik-megarad wants to merge 1 commit intoOneHQ:masterfrom
erik-megarad:master
Conversation
Contributor
|
@subwindow would you mind writing some specs for this change, please? |
Author
|
Since this happens at Rails boot time, I don't think you can write specs for it. Perhaps if you had a completely separate runner that didn't set |
Contributor
|
That's a good point. I see spec_helper has ENV["RUBYCAS_CONFIG_FILE"] hardcoded, perhaps you could set it before spec_helper is loaded in the test? I'll have a dig around later today if I get time. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the issues raised in issue #5.
For our deployment, we must have Cassy config options that are different for each instance running, but which are deterministic based on some easily grabbed config settings on the box. This makes using a yaml file impractical. This pull request allows you to set the configuration in Ruby code, such as in a Rails initializer: