-
Notifications
You must be signed in to change notification settings - Fork 14
Document and update extension relationships #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Easiest way to review is to look at the pages rendered in the github ui for the |
neilsjefferies
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be V1.0 any more.
awoods
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @zimeon . Two minor comments.
|
@neilsjefferies - I think the editors need to discuss what the version of the extensions spec (ie. the readme https://github.com/OCFL/extensions) means. We have a number (1.0) in that readme/spec and on all extensions but we don't say anything about what sort of change could be expected if we move from 1.0 to 1.1 or 2.0, the implications for extensions that declare a particular extensions spec number, or even how we preserve "old" extensions specification versions. I'm not convinced that we need to change the extension specification number for this change -- the validity of the current set of extensions is not changed and only the headers have been updated to improve/clarify linking between extensions. However, maybe working out what a change implies would help clarify. |
I agree that we should clarify the meaning of changes to the extensions spec version number. Unless we decide on changing that number with every commit (unlikely), we should safely be able to move this PR forward in the meantime. |
Fixes #92 and #93