[17.0][IMP] base_tier_validation: remove codepath returning a single value where two are expected #1233
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…where two are expected
Contributor
|
Hi @LoisRForgeFlow, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the two existing calls made to it,
_get_fields_to_write_validationis supposed to return a 2-tuple value, but there is a codepath in this method that returns a single (empty) list.This codepath seems unreachable anyway, since the function call is only triggered when a
writecall is made with at least one non-allowed field (that is, if_check_allow_write_under_validation()or_check_allow_write_after_validation()returnFalse)