[18.0][FIX] base_tier_validation: bypass approval only for consecutive tiers #1141
+20
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @LoisRForgeFlow, |
Saran440
force-pushed
the
18.0-fix-base_tier_validation-continue_review
branch
2 times, most recently
from
0d87adc to
3cb9cf9
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Contributor
|
@Saran440 is this PR still relevant? should we reopen? |
Member
Author
|
@LoisRForgeFlow Yes, please reopen it. The bug is still reproducible. |
Saran440
changed the title
Contributor
|
Hi @LoisRForgeFlow, |
Contributor
|
@Saran440 Looks like tests are failing, could you have a look? |
Saran440
force-pushed
the
18.0-fix-base_tier_validation-continue_review
branch
from
1f2830c to
6cb2c95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step to test:
tier.definitionand CheckBypass, if previous tier was validated by same reviewerIt should not auto-approve if the next reviewer is different (not the same approver).
After fix:
