[19.0][ADD] project_profitability_threshold_alert: Notify project followers and project manager about costs exceeding based on a set threshold #1660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and project manager about budget exceeding based on a set threshold
nihelgabsi-acsone
changed the title
nihelgabsi-acsone
force-pushed
the
19.0-project_budget_threshold_alert-nga
branch
2 times, most recently
from
050db67 to
be238cd
Compare
nihelgabsi-acsone
changed the title
nihelgabsi-acsone
force-pushed
the
19.0-project_budget_threshold_alert-nga
branch
from
be238cd to
5a29fe3
Compare
rousseldenis
requested changes
Jan 28, 2026
project_profitability_threshold_alert/models/project_project.py
Outdated
Show resolved
Hide resolved
project_profitability_threshold_alert/models/project_project.py
Outdated
Show resolved
Hide resolved
project_profitability_threshold_alert/models/project_project.py
Outdated
Show resolved
Hide resolved
| def _cron_find_costs_threshold_exceeded(self): | ||
| projects = self.env["project.project"].search([("active", "=", True)]) | ||
| for project in projects: | ||
| project._compute_is_cost_exceeded() |
There was a problem hiding this comment.
Is this really necessary ? The compute is triggered by its depends.
Author
There was a problem hiding this comment.
I need to execute _get_profitability_items() to get updated data related to project costs and revenues
| projects = self.env["project.project"].search([("active", "=", True)]) | ||
| for project in projects: | ||
| project._compute_is_cost_exceeded() | ||
| if project.is_cost_exceeded and not project.is_notfication_sent: |
There was a problem hiding this comment.
Those fields should be included in search criteria (add a dedicated method for the domain like _get_costs_threshold_notification_domain())
| email_layout_xmlid=None, | ||
| ) | ||
|
|
||
| @api.depends("costs_threshold", "company_id.project_costs_threshold") |
There was a problem hiding this comment.
So, no need of company_id.project_cost_threshold
project_profitability_threshold_alert/models/project_project.py
Outdated
Show resolved
Hide resolved
project_profitability_threshold_alert/models/project_project.py
Outdated
Show resolved
Hide resolved
| internal_user_followers += manager | ||
| return internal_user_followers | ||
|
|
||
| @api.onchange("costs_threshold") |
There was a problem hiding this comment.
Set is_notification_sent as computed / store=True depending on costs_threshold to avoid onchanges.
project_profitability_threshold_alert/models/res_config_settings.py
Outdated
Show resolved
Hide resolved
- Rename module to be more generic - Add costs vs revenues threshold
nihelgabsi-acsone
force-pushed
the
19.0-project_budget_threshold_alert-nga
branch
from
5a29fe3 to
1653c40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notify followers and project manager about costs exceeding based on a set threshold