Skip to content

Conversation

@atgalvez08
Copy link

@atgalvez08 atgalvez08 commented Jan 8, 2026

@BinhexTeam

This PR migrates the addon project_tag_hierarchy to Odoo 17.0 using oca-port, preserving the original addon history.

Main changes introduced during the migration:

  • Replace the deprecated name_get override with a computed display_name field using _compute_display_name, following Odoo 17 core guidelines.
  • Remove the custom recursion constraint on parent_id, as Odoo 17 already enforces recursion detection at core level for models using _parent_store, raising a UserError before model constraints are evaluated.
  • Add a test to explicitly cover recursion detection, aligned with the actual behavior of the Odoo 17 core.
  • Update tests to comply with OCA testing guidelines for Odoo 17 (TransactionCase and proper test tagging).

Fixes #1191

@atgalvez08 atgalvez08 force-pushed the 17.0-mig-project_tag_hierarchy branch from 69ca86e to 076cf5b Compare January 8, 2026 12:25
@atgalvez08 atgalvez08 marked this pull request as ready for review January 9, 2026 12:35
@leemannd
Copy link
Contributor

/ocabot migration project_tag_hierarchy

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jan 13, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 13, 2026
38 tasks
@jelenapoblet
Copy link

@rrebollo @antoniodavid would you guys review this please ?

Copy link

@rrebollo rrebollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review. LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link

@antoniodavid antoniodavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants