-
-
Notifications
You must be signed in to change notification settings - Fork 672
[16.0][IMP] pos_price_to_weight: selection of the price field #1478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
Conversation
legalsylvain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mihien. Thanks for your contribution. could you update the CONFIGURE section. A I think this option is a little obscure, so, I could be great to explain the use case when it's not the list_price field.
thanks !
| _name = "res.company" | ||
| _inherit = ["res.company"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| _name = "res.company" | |
| _inherit = ["res.company"] | |
| _inherit = "res.company" |
is enough
| price_to_weight_price_field_id = fields.Many2one( | ||
| string="Price To Weight Field", | ||
| comodel_name="ir.model.fields", | ||
| domain=[("model", "=", "product.product"), ("ttype", "=", "float")], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicking : is it possible to filter monetary field only ?
1b20e1a to
2cec9eb
Compare
|
@legalsylvain Hi Sylvain! I've rewritten my changes, as the goal was to be able to chose whether the taxes are included in the product's barcode or not. But I missed the fact that the prices with and without taxes are not fields of the product model in 16.0 anymore. |
| /* | ||
| Copyright (C) 2024 - Today: GRAP (http://www.grap.coop) | ||
| @author: Sylvain LE GAL (https://twitter.com/legalsylvain) | ||
| License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please git mv to make easy the review of the diff !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are too many changes to the file when converting to es and even with git mv when we make too many changes + rename the file there is no way (or at least none that I've found) to have git detect it as changes to one file. So I've separated the renaming and the conversion into two different commits
| _name = "res.company" | ||
| _inherit = "res.company" | ||
|
|
||
| is_price_to_weight_with_VAT = fields.Boolean( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default =True
2cec9eb to
97cfab9
Compare
97cfab9 to
140bfbf
Compare
Description
Add an option in the point of sale settings to indicate whether, when we scan a product barcode, the taxes are included or not.