[18.0] [FIX] mass_mailing_custom_unsubscribe: Allow redirect to mailing list manager on unsubscribe

[Shide]

When unsubscribing from a list, you cannot select a reason until you go to the mailing list manager. Now, you can choose with a system parameter to redirect directly to the mailing list manager and give the user in the first place an option to select a reason to opt out.

https://www.loom.com/share/7801fec1afb24e1bb51c74b0c1fdbe1d

MT-12505 @moduon @yajo @EmilioPascual @chienandalu @rafaelbn please review if you want 😄

[chienandalu]

For booleans, it's simpler to just check if the param is there or not (and that's how it will work if you use it as a res.config.settings boolean config_parameter

Suggested change

	if (
	request.env["ir.config_parameter"]
	.sudo()
	.get_param("mass_mailing.mailing_lists_unsubscribe_redirect", "0")
	== "1"
	):
	if (
	request.env["ir.config_parameter"]
	.sudo()
	.get_param("mass_mailing.mailing_lists_unsubscribe_redirect")
	):

[yajo]

Actually you have odoo.tools.str2bool for this specific purpose.

Suggested change

	if (
	request.env["ir.config_parameter"]
	.sudo()
	.get_param("mass_mailing.mailing_lists_unsubscribe_redirect", "0")
	== "1"
	):
	if str2bool(
	request.env["ir.config_parameter"]
	.sudo()
	.get_param("mass_mailing.mailing_lists_unsubscribe_redirect", "0")
	):

[yajo]

If you create the parameter but add no text to it, it will still be considered false, which goes against what the readme says.

I still suggest to use the str2bool approach. Otherwise, be more specific in the readme.

[chienandalu]

Code and functional review 👍

[yajo]

If you create the parameter but add no text to it, it will still be considered false, which goes against what the readme says.

I still suggest to use the str2bool approach. Otherwise, be more specific in the readme.

[yajo]

These are the docs I said above, that they are a bit misleading.

Suggested change

	you need to create the system parameter `mass_mailing.mailing_lists_unsubscribe_manager_redirect`.
	you need to create the system parameter `mass_mailing.mailing_lists_unsubscribe_manager_redirect` with value `1`.