[14.0][IMP] edi_oca: Do not retry exchange_send indefinitely #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ajaniszewska-dev
approved these changes
May 2, 2024
simahawk
reviewed
May 28, 2024
| return ( | ||
| # Safety check not to retry indefinitely | ||
| exchange_record.create_date >= (fields.Datetime.now() - timedelta(days=1)) | ||
| or self.env.context.get("_edi_send_break_on_error") |
Contributor
There was a problem hiding this comment.
why should retry when the ctx key is set? They key is there to let if fail directly.
|
Superseded by #980 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the backend is badly configured, with invalid URL. Or there might be other conditions.
It happens more frequently on Dev or Test server instances.
In such case we don't want to insist sending Exchange Record indefinitely.