Skip to content

Conversation

@gurneyalex
Copy link
Member

When this error is triggered by a manufacturing order, it is useful to
know which product / SN is causing the issue, esp. with large BoMs

Description of the issue/feature this PR addresses:

Current behavior before PR:

You can get an error message saying essentially "there is a problem with some serial number"

Desired behavior after PR is merged:

You get an error message giving the product name and serial number in the message.

Upstream PR odoo#51543

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

When this error is triggered by a manufacturing order, it is useful to
know which product / SN is causing the issue, esp. with large BoMs
Copy link
Member

@cubells cubells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

LGTM

Code review and test

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be merged in OCB, as this is modifying translations, and we can't handle translations different from core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants