CFE-4616: Fix control chars escaping in JSON serialization #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was an error running your pipeline, see logs for details. |
|
|
larsewi
reviewed
Dec 3, 2025
Contributor
larsewi
left a comment
larsewi
left a comment
There was a problem hiding this comment.
Thanks! I have some smaller comments on code style in regards to the consistency with the rest of the code base (see CONTRIBUTING.md). We can fix it for you if you want. Great work 🚀
m4rtinh4rt
force-pushed
the
fix-cfe-4616
branch
from
6468311 to
065c8ee
Compare
|
There was an error running your pipeline, see logs for details. |
Ticket: CFE-4616
m4rtinh4rt
force-pushed
the
fix-cfe-4616
branch
from
065c8ee to
6d4db47
Compare
|
There was an error running your pipeline, see logs for details. |
Contributor
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13117/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13117/ |
larsewi
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.