Skip to content

Fix ReadDouble Load #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Noggog merged 1 commit into from
Feb 23, 2026
Merged

Fix ReadDouble Load #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Noggog.CSharpExt/Streams/Binary/BinaryReadStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
if (diff > 0
&& diff < NearnessLength)
{
_stream.Read(NearnessBuffer, 0, (int)diff);

Check warning on line 77 in Noggog.CSharpExt/Streams/Binary/BinaryReadStream.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, Noggog.CSharpExt) 

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)

Check warning on line 77 in Noggog.CSharpExt/Streams/Binary/BinaryReadStream.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, Noggog.Testing) 

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)

Check warning on line 77 in Noggog.CSharpExt/Streams/Binary/BinaryReadStream.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, Noggog.Autofac) 

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)

Check warning on line 77 in Noggog.CSharpExt/Streams/Binary/BinaryReadStream.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, Noggog.CSharpExt) 

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)

Check warning on line 77 in Noggog.CSharpExt/Streams/Binary/BinaryReadStream.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, Noggog.Testing) 

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)

Check warning on line 77 in Noggog.CSharpExt/Streams/Binary/BinaryReadStream.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, CSharpExt.UnitTests) 

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)

Check warning on line 77 in Noggog.CSharpExt/Streams/Binary/BinaryReadStream.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, Noggog.WPF) 

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)
}
else
{
Expand Down Expand Up @@ -328,10 +328,10 @@
return _internalMemoryStream.ReadFloat();
}

public double ReadDouble()
{
LoadPosition(4);
return _internalMemoryStream.ReadDouble();
public double ReadDouble()
{
LoadPosition(8);
return _internalMemoryStream.ReadDouble();
}

public string ReadStringUTF8(int amount)
Expand All @@ -352,7 +352,7 @@

amount -= numRead;

_stream.Read(arr, numRead, amount);

Check warning on line 355 in Noggog.CSharpExt/Streams/Binary/BinaryReadStream.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, Noggog.CSharpExt) 

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)

Check warning on line 355 in Noggog.CSharpExt/Streams/Binary/BinaryReadStream.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, Noggog.Testing) 

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)

Check warning on line 355 in Noggog.CSharpExt/Streams/Binary/BinaryReadStream.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, Noggog.Autofac) 

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)

Check warning on line 355 in Noggog.CSharpExt/Streams/Binary/BinaryReadStream.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, Noggog.Testing) 

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)

Check warning on line 355 in Noggog.CSharpExt/Streams/Binary/BinaryReadStream.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, CSharpExt.UnitTests) 

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)

Check warning on line 355 in Noggog.CSharpExt/Streams/Binary/BinaryReadStream.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, Noggog.WPF) 

Avoid inexact read with 'System.IO.Stream.Read(byte[], int, int)' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2022)
_streamPos += amount;
return SpanExt.StringUTF8(arr.AsSpan().Slice(0, amount + numRead));
}
Expand Down
Loading