Feature/http support and simplified category selector #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-> category selector now takes a numeric id instead of pulling the full category list. Renamed UI facing category to folder. Add a gitignore and set it to ignore vim swap files.
…e saved settings values instead of the most recently posted ones. I think we want to use the most recently posted versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up the pull-request I noticed that my editor try to cleanup the mixed whitespace on some of the files. If that's a problem I can go back and remove the whitespace changes. If that isn't you can view the diff on GitHub and add w=1 to ignore the whitespace changes.
After getting into the code, it looks like the token was only used for the file download, none of the other api requests were using it. Everything is session based, using curl's built in cookie support and initially authenticating over basic auth.
I added support for http/https. And changed the category selection to take in an id instead of generating a dropdown of the full list of categories.
I also, made a change to:
proxy.php
to not display all errors. Our stage server's apache config was messed up and it was killing all the thumbnails and any asset that was getting proxied in. I believe the phase two has better error handling / logging in scope. So, I'm assuming we'd want to catch errors and log them there in the next body of work.