Reduce team allocation for path reservation

[sunzenshen]

Description

Also rename ConVar enabling the path reservation system to be more general

Toolchain

• Windows MSVC VS2022

Linked Issues

• related OnStuck location sharing for NavArea avoidance #1598

[sunzenshen]

To address comments:

• OnStuck location sharing for NavArea avoidance #1598 (comment)
• OnStuck location sharing for NavArea avoidance #1598 (comment)

[Rainyan]

Should bMax be true instead of false here for the cvar ctor?

[Rainyan]

I just noticed we have the cvar neo_bot_path_reservation_enabled, and also another cvar called neo_bot_path_reservation_enable. Should we merge these into a single cvar?

$ git log --oneline -n 1
fba77b2f (HEAD -> path-reservation-team-arrays-optimization) Reduce team allocation for path reservation

$ grep -snrI neo_bot_path_reservation_enable[^d] src
src/game/server/neo/bot/neo_bot_path_cost.cpp:9:ConVar neo_bot_path_reservation_enable("neo_bot_path_reservation_enable", "1", FCVAR_NONE,
src/game/server/neo/bot/neo_bot_path_cost.cpp:26:       m_bIgnoreReservations = !neo_bot_path_reservation_enable.GetBool();
src/game/server/neo/bot/neo_bot_path_cost.cpp:115:              if ( neo_bot_path_reservation_enable.GetBool()

$ grep -snrI neo_bot_path_reservation_enabled src
src/game/server/neo/bot/neo_bot_path_compute.cpp:11:extern ConVar neo_bot_path_reservation_enabled;
src/game/server/neo/bot/neo_bot_path_compute.cpp:18:    if (!neo_bot_path_reservation_enabled.GetBool() || !path.IsValid())
src/game/server/neo/bot/neo_bot_path_reservation.cpp:10:ConVar neo_bot_path_reservation_enabled("neo_bot_path_reservation_enabled", "1", FCVAR_NONE, "Enable the bot path reservation system.");
src/game/server/neo/bot/neo_bot_path_reservation.h:80:extern ConVar neo_bot_path_reservation_enabled;

GitHub requires me to write something deep and insightful in this field.

[sunzenshen]

Realized that m_bIgnoreReservations was already set based on neo_bot_path_friendly_reservation_enable in the constructor, so there's no need to check the latter again.