Fixed MAKE_NVAPI_VERSION calls
#15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@sujatas-NV @planke-NV @arunimam-NV |
…EHULLSHADEREX_VER_2` using old structs in `MAKE_NVAPI_VERSION` calls.
pzychotic
force-pushed
the
fix-version-defines
branch
from
5167505 to
33d410b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
NVAPI_D3D11_CREATEVERTEXSHADEREX_VER_3andNVAPI_D3D11_CREATEHULLSHADEREX_VER_2using old structs inMAKE_NVAPI_VERSIONcalls.If you try to use the current versions of these structs like so:
You'll end up with the latest version of the struct:
NvAPI_D3D11_CREATE_VERTEX_SHADER_EX_V3But the
versionmember encodes the size of the V2 struct because of the wrong argument toMAKE_NVAPI_VERSION.I assume you'll use the encoded size to memcpy the struct internally, which would miss the new member
BOOL UseSpecificShaderExtadded to V3.Same thing for
NvAPI_D3D11_CREATE_HULL_SHADER_EX.