Skip to content

[TASK] Rename Rule\Rule to Property\Declaration#1508

Merged
oliverklee merged 2 commits intomainfrom
task/rename-rule
Feb 12, 2026
Merged

[TASK] Rename Rule\Rule to Property\Declaration#1508
oliverklee merged 2 commits intomainfrom
task/rename-rule

Conversation

@JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Feb 12, 2026

A property declaration is not a rule.

Ref: https://developer.mozilla.org/en-US/docs/Web/API/CSS_Object_Model/CSS_Declaration

Add a class_alias to avoid a breaking change, and deprecate the original class name.

@JakeQZ
[TASK] Rename Rule\Rule to Property\Declaration
cdee953 
A property declaration is not a rule.

Ref: https://developer.mozilla.org/en-US/docs/Web/API/CSS_Object_Model/CSS_Declaration

Add a `class_alias` to avoid a breaking change, and deprecate the original
class name.
@JakeQZ JakeQZ requested a review from oliverklee February 12, 2026 14:10
@JakeQZ JakeQZ self-assigned this Feb 12, 2026
@JakeQZ JakeQZ added cleanup deprecation A method, property, or some functionality has been deprecated. refactor For PRs that refactor code without changing functionality labels Feb 12, 2026
@coveralls
Copy link

coveralls commented Feb 12, 2026 •
edited
Loading

Coverage Status

coverage: 72.779% (-0.03%) from 72.813%
when pulling d89df80 on task/rename-rule
into 1ce3447 on main.

@JakeQZ
Copy link
Collaborator Author

JakeQZ commented Feb 12, 2026

I did git mv for the main class file, but had to replace it for the class_alias, so GitHub is not showing the diffs as it should :/

oliverklee
oliverklee requested changes Feb 12, 2026
View reviewed changes
Copy link
Collaborator

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

… and we also should rename the tests change change them to use the new class. (I'd also be fine with doing that in a follow-up PR).

@JakeQZ
Copy link
Collaborator Author

JakeQZ commented Feb 12, 2026

… and we also should rename the tests change change them to use the new class. (I'd also be fine with doing that in a follow-up PR).

I was planning to do that in follow-up PRs - we won't be able to remove the deprecated class until that's done.

@JakeQZ JakeQZ requested a review from oliverklee February 12, 2026 14:58
@oliverklee oliverklee merged commit 802cebe into main Feb 12, 2026
24 checks passed
@oliverklee oliverklee deleted the task/rename-rule branch February 12, 2026 15:00
JakeQZ added a commit that referenced this pull request Feb 12, 2026
@JakeQZ
[TASK] Add changelog entry for #1508
08ea04a
oliverklee pushed a commit that referenced this pull request Feb 12, 2026
@JakeQZ
[TASK] Add changelog entry for #1508 (#1510)
4444140
JakeQZ added a commit that referenced this pull request Feb 12, 2026
@JakeQZ
[TASK] Use Property\Declaration in CSSBlockList
c5c5e1d 
This replaces `Rule\Rule`, following #1508.
@JakeQZ JakeQZ mentioned this pull request Feb 12, 2026
Merged
oliverklee pushed a commit that referenced this pull request Feb 12, 2026
@JakeQZ
[TASK] Use Property\Declaration in CSSBlockList (#1512)
27da0c8 
This replaces `Rule\Rule`, following #1508.
JakeQZ added a commit that referenced this pull request Feb 13, 2026
@JakeQZ
[TASK] Use Property\Declaration in RuleContainer classes
bc5360c 
This replaces `Rule\Rule`, following #1508.
@JakeQZ JakeQZ mentioned this pull request Feb 13, 2026
Merged
JakeQZ added a commit that referenced this pull request Feb 13, 2026
@JakeQZ
[TASK] Use Property\Declaration in RuleContainer classes
a4f47b1 
This replaces `Rule\Rule`, following #1508.
oliverklee pushed a commit that referenced this pull request Feb 13, 2026
@JakeQZ
[TASK] Use Property\Declaration in RuleContainer classes (#1513)
399afab 
This replaces `Rule\Rule`, following #1508.
JakeQZ added a commit that referenced this pull request Feb 13, 2026
@JakeQZ
[TASK] Use Property\Declaration in DeclarationBlockTest
e860529 
This replaces `Rule\Rule`, following #1508.

Also use `getPropertyName()` rather than `getRule()` which was deprecated in

This covers both the 'functional' and 'unit' flavours of the `TestCase`, and
the trait that does most of the heavy lifting for the 'unit' flavour.
@JakeQZ JakeQZ mentioned this pull request Feb 13, 2026
Merged
JakeQZ added a commit that referenced this pull request Feb 13, 2026
@JakeQZ
[TASK] Use Property\Declaration in DeclarationBlockTest (#1514)
567e390 
This replaces `Rule\Rule`, following #1508.

Also use `getPropertyName()` rather than `getRule()` which was deprecated
in #1506.

This covers both the 'functional' and 'unit' flavours of the `TestCase`, and
the trait that does most of the heavy lifting for the 'unit' flavour.
JakeQZ added a commit that referenced this pull request Feb 13, 2026
@JakeQZ
[TASK] Use Property\Declaration in ValueTest DocBlock references
71e44be 
This replaces `Rule\Rule`, following #1508.
@JakeQZ JakeQZ mentioned this pull request Feb 13, 2026
Merged
JakeQZ added a commit that referenced this pull request Feb 13, 2026
@JakeQZ
[TASK] Use Property\Declaration in RuleSetTest
55ff551 
This replaces `Rule\Rule`, following #1508.
@JakeQZ JakeQZ mentioned this pull request Feb 13, 2026
Merged
JakeQZ added a commit that referenced this pull request Feb 13, 2026
@JakeQZ
[TASK] Use Property\Declaration in CSSBlockListTest
5800c4e 
This replaces `Rule\Rule`, following #1508.
@JakeQZ JakeQZ mentioned this pull request Feb 13, 2026
Merged
JakeQZ added a commit that referenced this pull request Feb 13, 2026
@JakeQZ
[TASK] Use Property\Declaration in generic DeclarationBlockTest
79c0ba1 
This replaces `Rule\Rule`, following #1508.
@JakeQZ JakeQZ mentioned this pull request Feb 13, 2026
Merged
oliverklee pushed a commit that referenced this pull request Feb 14, 2026
@JakeQZ
[TASK] Use Property\Declaration in ValueTest DocBlock references (#…
32dce4b 
…1515)

This replaces `Rule\Rule`, following #1508.
oliverklee pushed a commit that referenced this pull request Feb 14, 2026
@JakeQZ
[TASK] Use Property\Declaration in RuleSetTest (#1516)
b9b78b8 
This replaces `Rule\Rule`, following #1508.
oliverklee pushed a commit that referenced this pull request Feb 14, 2026
@JakeQZ
[TASK] Use Property\Declaration in CSSBlockListTest (#1517)
cc48a61 
This replaces `Rule\Rule`, following #1508.
oliverklee pushed a commit that referenced this pull request Feb 14, 2026
@JakeQZ
[TASK] Use Property\Declaration in generic DeclarationBlockTest (#…
fd15e78 
…1518)

This replaces `Rule\Rule`, following #1508.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels

cleanup deprecation A method, property, or some functionality has been deprecated. refactor For PRs that refactor code without changing functionality

Projects

None yet

Milestone

9.2.0: New features, bug fixes and de...

Development

Successfully merging this pull request may close these issues.

3 participants

@JakeQZ @coveralls @oliverklee