Refactored save integration to allow for arbitrary save data container objects (#317)#318
Open
gregorhcs wants to merge 2 commits intoMothCocoon:5.xfrom
Open
Refactored save integration to allow for arbitrary save data container objects (#317)#318gregorhcs wants to merge 2 commits intoMothCocoon:5.xfrom
gregorhcs wants to merge 2 commits intoMothCocoon:5.xfrom
Conversation
373190d to
af300a9
Compare
gregorhcs
commented
Jan 12, 2026
| UFlowSaveGame() {} | ||
|
|
||
| virtual const FFlowSaveData& GetSaveData() const override { return FlowSaveData; } | ||
| virtual FFlowSaveData& GetSaveDataMutable() override { return FlowSaveData; } |
Contributor
Author
There was a problem hiding this comment.
Hmm, I'm thinking now it would be better if the interface would also allow BP implementation. I'll add that
Contributor
Author
There was a problem hiding this comment.
Ok, so I tried bending the function signature for a while to allow implementing the interface in BP, but I think it's impossible for BP functions to return references, so I'd say we leave it like that. It's not really a regression, since previously there was no way to customize the container at all.
acd78b4 to
22f316a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#317 Implemented generic save data container support for flow.
The Flow Subsystem now saves and loads from any
UObjectimplementing the newIFlowSaveDataContainerInterface. The interfaces provides mutable and const access to the newFFlowSaveDatastruct, which wrapsFFlowComponentSaveDataandFFlowAssetSaveData.To retain compatibility with
UFlowSaveGame, that class now implements the new interface, thus projects can easily switch to the new API on the subsystem. I've marked the old API as deprecated.