Add missing serialization calls for saved data structs#227
Open
dyanikoglu wants to merge 1 commit intoMothCocoon:5.xfrom
Open
Add missing serialization calls for saved data structs#227dyanikoglu wants to merge 1 commit intoMothCocoon:5.xfrom
dyanikoglu wants to merge 1 commit intoMothCocoon:5.xfrom
Conversation
|
@dyanikoglu this change doesnt include a version for the manual serialization, so not all changes in newer version will be backwards compatible. |
Contributor
|
Indeed, this might break loading already created saves in released games. |
Contributor
Author
|
In my custom save system, I'm serializing those structs manually and writing into saved data. If it's likely break compatibility with existing projects, the PR can be closed. |
MothDoctor
force-pushed
the
5.x
branch
2 times, most recently
from
402b773 to
1a4a2d9
Compare
MothDoctor
force-pushed
the
5.x
branch
3 times, most recently
from
4b00fe8 to
daa3fef
Compare
MothDoctor
force-pushed
the
5.x
branch
4 times, most recently
from
acd78b4 to
22f316a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why those calls were not included in serialize functions.