fix: set isExternalSign to true for delegated transactions

[khanti42]

Explanation

EIP-7702 delegated transactions were incorrectly using the user's EOA nonce, causing nonce conflicts and preventing transactions from appearing in the activity tab. In EIP-7702, the delegation address manages its own nonce sequence, not the user's EOA.

This PR sets isExternalSign for EIP-7702 txs.

References

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

---

Note

Addresses incorrect nonce handling for EIP-7702 delegated/batch transactions.

• Set isExternalSign = true when nestedTransactions are present to bypass EOA nonce assignment for EIP-7702 batches
• Record delegationAddress for metrics without using it to infer isExternalSign
• Update CHANGELOG.md under Fixed to reflect the behavior change

^{Written by Cursor Bugbot for commit 99b756f. This will update automatically on new commits. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

[cursor]

EIP-7702 batch isExternalSign override by gas fee token check

Medium Severity

The new isExternalSign = isEIP7702Batch can be overridden by checkGasFeeTokenBeforePublish when a transaction has both nestedTransactions and a gasFeeToken, and the user has sufficient native balance. The checkGasFeeTokenBeforePublish function unconditionally sets isExternalSign = false in this case, which would cause the original nonce conflicts for EIP-7702 batch transactions that the PR aims to fix.

 

[matthewwalsh0]

Sorry, this is the same issue as before.

EIP-7702 batch transactions can still be signed locally by the EOA itself and more typically are.

The only exceptions to that are when the gas station EIP-7702 flow is used as it's signed by our relay.

If we're missing a scenario when a transaction is signed externally, then we need to update isExternalSign externally (as we do for gas station EIP-7702 currently) or trigger it more specifically internally, assuming we have that context internally without unnecessary coupling.