Feature: example linear registration pipeline #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seankmartin
changed the title
There was a problem hiding this comment.
Pull request overview
This PR implements a feature to support linear registration workflows with custom clipping behavior for annotation layers across different coordinate spaces. The implementation adds a clipDimensionsWeight property that allows fine-grained control over which dimensions should be clipped during annotation rendering.
Changes:
- Added
clipDimensionsWeighttracking and state management across viewer components - Implemented Python bindings for
clip_dimensions_weightin annotation layers and viewer state - Created a comprehensive example script demonstrating interactive linear registration using point annotations
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/layer_groups_layout.ts | Added clipDimensionsWeight to common viewer state |
| src/layer_group_viewer.ts | Added clipDimensionsWeight property and type import |
| src/layer/annotation/index.ts | Added JSON key constant and state management for clipDimensionsWeight |
| src/data_panel_layout.ts | Added clipDimensionsWeight to ViewerUIState interface and common state |
| src/annotation/renderlayer.ts | Implemented clip dimension weight application in annotation projection parameters |
| src/annotation/annotation_layer_state.ts | Created TrackableClipDimensionsWeight class for state management |
| python/neuroglancer/viewer_state.py | Added Python bindings for clip_dimensions_weight and LinkedDisplayDimensions |
| python/neuroglancer/init.py | Exported LinkedDisplayDimensions |
| python/examples/example_linear_registration.py | Added comprehensive linear registration workflow example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
seankmartin
commented
Jan 29, 2026
| wireFrame: viewer.wireFrame, | ||
| enableAdaptiveDownsampling: viewer.enableAdaptiveDownsampling, | ||
| visibleLayerRoles: viewer.visibleLayerRoles, | ||
| clipDimensionsWeight: viewer.clipDimensionsWeight, |
Author
There was a problem hiding this comment.
not sure this needed on both the data panel layout and layer group viewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.