feat: Add KeywordCase rule for Fortran keyword casing#145
Open
Arjunmehta312 wants to merge 1 commit intoMetOffice:masterfrom
Open
feat: Add KeywordCase rule for Fortran keyword casing#145Arjunmehta312 wants to merge 1 commit intoMetOffice:masterfrom
Arjunmehta312 wants to merge 1 commit intoMetOffice:masterfrom
Conversation
Adds new rule to enforce consistent casing of Fortran keywords using regex patterns. Default enforces lowercase but supports custom patterns.
Author
|
Please do review and allow merging |
MatthewHambley
requested changes
Feb 20, 2025
Collaborator
MatthewHambley
left a comment
There was a problem hiding this comment.
You talk about testing and documentation in the ticket but I only see the implementation in the diff. Did you forget to commit or push later changes?
Author
|
Oh sorry my bad im still getting to those commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add KeywordCase rule to enforce consistent Fortran keyword casing
Description
Adds a new rule to enforce consistent casing of Fortran keywords through configurable regex patterns. This helps maintain consistent code style across Fortran codebases by ensuring keywords like PROGRAM, SUBROUTINE, etc. follow specified case patterns.
Implementation Details
KeywordCaseclass that inherits fromFortranRule^[a-z]+$) but allows custom patternsExample Configuration
Testing
Added comprehensive test suite including:
Documentation
Related Issues
Closes #144
Checklist