Skip to content

Decide if partitioning all meshes in a multigrid mesh file#289

Draft
ukmo-juan-castillo wants to merge 2 commits intoMetOffice:mainfrom
ukmo-juan-castillo:lfric2lfric_no_multi_partition
Draft

Decide if partitioning all meshes in a multigrid mesh file#289
ukmo-juan-castillo wants to merge 2 commits intoMetOffice:mainfrom
ukmo-juan-castillo:lfric2lfric_no_multi_partition

Conversation

@ukmo-juan-castillo
Copy link

@ukmo-juan-castillo ukmo-juan-castillo commented Feb 25, 2026

PR Summary

Sci/Tech Reviewer:
Code Reviewer:

Partitioning all meshes in the multigrid mesh file imposes a series of conditions regarding the number of CPUs that can be used in a job. For flexibility, it would be desirable to give the option of partitioning all multigrid meshes or not. This functionality is already present in lfric_core via the any_maps parameter of the get_partition subroutine of the panel_decomposition_type object. On the other hand, this object subroutine is not called directly in most applications, so this functionality should be made more accessible.

The solution proposed here is the creation of a logical variable in the global_mesh object, with set/get subroutines, indicating if the multiple meshes have to be partitioned. This is similar to what is presently done, where the global_mesh variable ntarget_meshes is used to find if there are multiple meshes.

Other solutions have been considered, for example:
. Extracting the any_maps parameter of the subroutine get_partition contained in the object panel_decomposition_type in successive subroutine calls until it can be used in the calling subroutine create_local_mesh. This would imply large changes in both lfric_core and lfric_apps
. Doing the same as before, but using optional subroutine parameters. Although this would minimise the number of changes in lfric_core and lfric_apps, the addition of new optional subroutine parameters is discouraged.
. Make changes in lfric applications to use the existing any_maps parameter of the subroutine get_partition. Lfric_core would not change, but this would imply duplicating large pieces of lfric_core code in the lfric_app applications that would make use of this functionality.
. Removing the checks altogether. This probably has implications in code robustness and cause runtime issues.

Any other suggestion by the reviewer would be considered and tested if necessary.

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Core rose-stem suite
  • If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_core - lfric2lfric_no_multi_partition_core/run1

Suite Information

Item Value
Suite Name lfric2lfric_no_multi_partition_core/run1
Suite User juan.m.castillo
Workflow Start 2026-02-25T15:47:23
Groups Run all
Dependency Reference Main Like
lfric_core ukmo-juan-castillo/lfric_core@lfric2lfric_no_multi_partition False
SimSys_Scripts MetOffice/SimSys_Scripts@2025.12.1 True

Task Information

✅ succeeded tasks - 384

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@github-actions github-actions bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Feb 25, 2026
@ukmo-juan-castillo ukmo-juan-castillo requested a review from a team as a code owner February 25, 2026 15:46
@github-actions github-actions bot added cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels Feb 25, 2026
@mo-rickywong mo-rickywong marked this pull request as draft February 26, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Select partitioning of multigrid meshes

1 participant