Skip to content

Fix JEDI_LFRic forecast_pseudo test config#300

Open
DanStoneMO wants to merge 6 commits intoMetOffice:mainfrom
DanStoneMO:iap-configs
Open

Fix JEDI_LFRic forecast_pseudo test config#300
DanStoneMO wants to merge 6 commits intoMetOffice:mainfrom
DanStoneMO:iap-configs

Conversation

@DanStoneMO
Copy link

PR Summary

Sci/Tech Reviewer:
Code Reviewer:

When running lfric-jedi (https://github.com/JCSDA-internal/lfric-jedi) using its 'mobbalt' opt, the JEDI-LFRic interface is built and tested as part of the workflow. Following PR #174 merging, the testing fails due to missing configuration sections and options in the forecast_pseudo test. See: https://cylchub/services/cylc-review/view/daniel.stone?&suite=mob-la-174-4&no_fuzzy_time=0&path=log/job/1/test_jelf__spice_gnu_debug/01/job.err for output.

This PR updates the forecast_pseudo model configuration to include the required options, as well as the iodef to reflect a recent name change in two of the fields.

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite - results
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

JEDI_LFRic tests are not tested when running the rose-stem suite. I have manually triggered and confirmed it runs without error and can provide output on request. The repository from before the bug emerged no longer builds, so I am currently unable to determine if the results have changed. (Are any KGOs available?)

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@DanStoneMO DanStoneMO self-assigned this Feb 26, 2026
@DanStoneMO DanStoneMO added the bug Something isn't working label Feb 26, 2026
@github-actions github-actions bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Feb 26, 2026
@github-actions github-actions bot added cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels Feb 26, 2026
@DanStoneMO
Copy link
Author

I've just tested the other jedi_lfric tests, and all except for forecast fail in the same way. I'll be applying the same fix to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cla-signed The CLA has been signed as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JEDI Interface testing fails when lfric-jedi is run

1 participant