Fix JEDI_LFRic forecast_pseudo test config#300
Open
DanStoneMO wants to merge 6 commits intoMetOffice:mainfrom
Open
Fix JEDI_LFRic forecast_pseudo test config#300DanStoneMO wants to merge 6 commits intoMetOffice:mainfrom
DanStoneMO wants to merge 6 commits intoMetOffice:mainfrom
Conversation
'snow_mixing_ratio'.
Author
|
I've just tested the other jedi_lfric tests, and all except for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer:
When running lfric-jedi (https://github.com/JCSDA-internal/lfric-jedi) using its 'mobbalt' opt, the JEDI-LFRic interface is built and tested as part of the workflow. Following PR #174 merging, the testing fails due to missing configuration sections and options in the
forecast_pseudotest. See: https://cylchub/services/cylc-review/view/daniel.stone?&suite=mob-la-174-4&no_fuzzy_time=0&path=log/job/1/test_jelf__spice_gnu_debug/01/job.err for output.This PR updates the
forecast_pseudomodel configuration to include the required options, as well as the iodef to reflect a recent name change in two of the fields.Code Quality Checklist
Testing
JEDI_LFRic tests are not tested when running the rose-stem suite. I have manually triggered and confirmed it runs without error and can provide output on request. The repository from before the bug emerged no longer builds, so I am currently unable to determine if the results have changed. (Are any KGOs available?)
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review