Conversation
|
@cameronbateman-mo , @yaswant , @t00sa , @Pierre-siddall , @MatthewHambley - a small extension for site-specific configurations. Ready for review. |
There was a problem hiding this comment.
Hi @hiker. I'm having a hard time figuring this one out.
It sounds like you want to add the ability to override command-line options on a per-site basis. That makes sense. But in the default Config you've hard-coded the command-line options to set mpi=False. That seems like a strange thing to do. Presumably, this function is meant to be overloaded by site-specific Configs. In which case, I wouldn't have the base class function do anything - just comment out line 62 and replace it with a simple pass statement. Or maybe even raise a NotImplementedError ?
2 participants
Add a callback to site config after command line options are defined, so that site-config can add more options or change defaults.