Skip to content

Git ignore#170

Merged
t00sa merged 4 commits intoMetOffice:mainfrom
james-bruten-mo:git_ignore
Jan 29, 2026
Merged

Git ignore#170
t00sa merged 4 commits intoMetOffice:mainfrom
james-bruten-mo:git_ignore

Conversation

@james-bruten-mo
Copy link
Collaborator

@james-bruten-mo james-bruten-mo commented Jan 29, 2026

PR Summary

Sci/Tech Reviewer:
Code Reviewer: @t00sa

Instead of using a hard-coded list of ignored files when rsyncing, generate a list of ignored files using git status --ignored -s and use this instead.

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • This change has been tested appropriately (please describe)

Tested by running against lfric_apps vn3.0 test suite

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Security considerations have been addressed
  • Performance impact is acceptable

@james-bruten-mo james-bruten-mo requested a review from t00sa January 29, 2026 09:30
@james-bruten-mo james-bruten-mo marked this pull request as ready for review January 29, 2026 09:30
Copy link
Contributor

@t00sa t00sa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me.

@t00sa t00sa merged commit 6434cc1 into MetOffice:main Jan 29, 2026
17 checks passed
@jennyhickson jennyhickson added this to the Spring 2026 milestone Jan 29, 2026
r-sharp pushed a commit to r-sharp/SimSys_Scripts that referenced this pull request Jan 30, 2026
Instead of using a hard-coded list of ignored files when
rsyncing, generate a list of ignored files using git status
--ignored -s and use this instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants