Merged
Conversation
Co-authored-by: Sam Clarke-Green <74185251+t00sa@users.noreply.github.com>
Co-authored-by: Sam Clarke-Green <74185251+t00sa@users.noreply.github.com>
Co-authored-by: Sam Clarke-Green <74185251+t00sa@users.noreply.github.com>
Co-authored-by: Sam Clarke-Green <74185251+t00sa@users.noreply.github.com>
t00sa
approved these changes
Jan 28, 2026
Contributor
t00sa
left a comment
There was a problem hiding this comment.
Looks good. Just one suggestion about where to put the basicConfig() call
Contributor
|
I've ticked the boxes I didn't tick yesterday and the update looks good too |
ericaneininger
requested changes
Jan 29, 2026
Co-authored-by: Erica Neininger <107684099+ericaneininger@users.noreply.github.com>
…s_Scripts into suite_merge_script
james-bruten-mo
commented
Jan 29, 2026
Collaborator
Author
james-bruten-mo
left a comment
There was a problem hiding this comment.
Thanks Erica, those changes are all done. For the opts == None comments, I've not modified by those comments, but have added a function that checks the structure of the dependencies dictionary looks roughly right. An example of it failing is at https://cylchub/services/cylc-review/view/james.bruten?&suite=u-dn674%2Frun3&no_fuzzy_time=0&path=log/job/1/extract/01/job.err
| if not isinstance(opts, list): | ||
| opts = [opts] | ||
|
|
||
| for i, values in enumerate(opts): |
Closed
20 tasks
ericaneininger
approved these changes
Jan 30, 2026
Contributor
ericaneininger
left a comment
There was a problem hiding this comment.
Thanks for taking the time to address all comments. Happy to approve.
r-sharp
pushed a commit
to r-sharp/SimSys_Scripts
that referenced
this pull request
Jan 30, 2026
* copy changes from apps * revert accidental changes * fix * allow multiple sources * add merge_sources script * make path * bug * bug * fix merge * mirror fix * setup merging of branches * ruff * remove remote * working merge script * add another error * modify argument order * Update github_scripts/get_git_sources.py Co-authored-by: Sam Clarke-Green <74185251+t00sa@users.noreply.github.com> * Update github_scripts/merge_sources.py Co-authored-by: Sam Clarke-Green <74185251+t00sa@users.noreply.github.com> * Update github_scripts/merge_sources.py Co-authored-by: Sam Clarke-Green <74185251+t00sa@users.noreply.github.com> * Update github_scripts/rose_stem_extract_source.py Co-authored-by: Sam Clarke-Green <74185251+t00sa@users.noreply.github.com> * update to use logger * loggin gchanges * loggin gchanges * logging changes * logging changes * logging changes * logging changes * logging changes * move basicconfig * Apply suggestion from @ericaneininger Co-authored-by: Erica Neininger <107684099+ericaneininger@users.noreply.github.com> * cr changes --------- Co-authored-by: Sam Clarke-Green <74185251+t00sa@users.noreply.github.com> Co-authored-by: Erica Neininger <107684099+ericaneininger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: @t00sa
Code Reviewer: @ericaneininger
Initial attempt at a script to merge different git branches for use in suites. The changes have been tested with the LFRic suites and with the lfric_apps rose-stem at
vn3.0. If we think this is a good idea I'll also modify the UM suites to use this extraction method to maintain consistency.These changes allow the
dependencies.yamlfile to specify multiple branches to merge together. This can be done by:which will clone the first source and then merge each subsequent source into this. It's currently setup to ignore merge conflicts in
rose-stemanddependencies.yamlas these files aren't important for running scientific suites.Code Quality Checklist
Testing
LFRic standalone suites and lfric_apps rose-stem at vn3.0
Security Considerations
AI Assistance and Attribution
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review