Conversation
james-bruten-mo
left a comment
There was a problem hiding this comment.
Can we keep the name Lint please, otherwise fine, except for a few extra ruff failures in the CI
.github/workflows/lint.yml
Outdated
| jobs: | ||
| check: | ||
| name: Lint | ||
| name: Validate |
There was a problem hiding this comment.
This isn't validating - let's stick with Lint
There was a problem hiding this comment.
Done.
Few things needed addressing:
- What do you want to do with
F841 Local variable `raw_code` is assigned to but never used
--> umdp3_fixer/whitespace.py:261:13
|
259 | try:
260 | with open(filename) as fortran_file:
261 | raw_code = fortran_file.readlines()
| ^^^^^^^^
262 | except EnvironmentError:
263 | print(can you see where raw_code is used?
- We need to tidy the code base addressing "undefined-local-with-import-star": F504 (ignored in ruff config) and F403 (ignored in code with
#noqa) in a separate PR or wait until Multi-file analysis astral-sh/ruff#7447 is available upstream.
There was a problem hiding this comment.
Thanks
I think 1 can just be deleted - all the code for the umdp3 scripts is in SimSys_Scripts and a grep of raw_code only returns that one example.
The import with * needs to stay in the upgrade macro files as this is the recommended way of importing macros. It's just one we'll need to ignore
There was a problem hiding this comment.
Thanks for clarifying that. Yes, we leave star imports, but will keep an eye on ruff#7447.
james-bruten-mo
left a comment
There was a problem hiding this comment.
Thanks, looks good now
Description
Summary
Bump superlinter
Changes
Dependency
List dependent changes. Can use build-group logic here.
Impact
Discuss any potential impacts this feature may have on existing functionalities.
Checklist