Skip to content

Umdp3 checker in python#153

Merged
yaswant merged 85 commits intoMetOffice:mainfrom
r-sharp:umdp3_checker_in_python
Jan 22, 2026
Merged

Umdp3 checker in python#153
yaswant merged 85 commits intoMetOffice:mainfrom
r-sharp:umdp3_checker_in_python

Conversation

@r-sharp
Copy link
Contributor

@r-sharp r-sharp commented Dec 18, 2025 •
edited by jennyhickson
Loading

Sci/Tech Reviewer: @jennyhickson
Code Reviewer: @yaswant

Description

Summary

Replacing the old Perl umdp3 compliance checking script with a half baked Python one.

Changes

Remove all old Perl files.
Add Python translations after some heavy refactoring.
This provides a framework, and some very simple tests to run on Fortran code.
It will need some tweaking as we stumble over the defficiencies we see when used in anger.

Impact

Replaces a set of Perl scripts which was hardwired to FCM to a Python version capable of using git_bdiff

Issues addressed

Resolves

One of the last remaining Perl script uses in the toolset
Hardwiring of our style checker to FCM

Checklist

  • I have performed a self-review of my own changes

Roddy Sharp and others added 30 commits July 3, 2025 13:40
Adding initial files - created by Claude AI and Yash to begin
4237f78 
investigations as to whether it's worked and how it can be improved.
The Python version runs - however output is nothing like the original
5f5502d 
and is to std out whereas the origianl wrote to std err. It's not clear
if the Python version terminated after the first file with errors, or
genuinely didn't spot the errors in the other files.
Branch used to look for errors is  :
https://code.metoffice.gov.uk/svn/um/main/branches/dev/roddysharp/vn13.9_deliberate_umdp3_failures
@r-sharp
Merge branch 'MetOffice:main' into umdp3_checker_in_python
fdb9142
@r-sharp
Hacking the code to force 1 file per thread. This produces output for…
1be77b5 
… all the edited files.
@r-sharp
Instrumenting the perl to count files... and the python to find files…
96777ac 
… in trunk mode...
@r-sharp
Refactor umdp3_check.py and add debug log files for compliance checks
858ec23
@r-sharp
adding the executable mode to the python file.
0075bc3
@r-sharp
Adding some more debugging prints around repos selection in trunk/sui…
96f8535 
…te mode
@r-sharp
rEMOVING (COMMENTING OUT) SOME OLDER DEBUG PRINTS
368057c
@r-sharp
More debugging print statements to track what is added to extracts list
339eac4
@r-sharp
Moving the 'extracts' logic completely out of the suite/not suite umd…
944067a 
…p3_checkas I think Perl did it for both cases..
@r-sharp
Trying to tame the no. of files the Python version now looks at...
f704bc1
@r-sharp
And fix the path prepend that I had to add for a trunk WC but fails f…
8b33d37 
…or a Trunk in suite..
@r-sharp
Hopefully sorting the duplication of files listed for checking
b223667
@r-sharp
Merge branch 'MetOffice:main' into umdp3_checker_in_python
79767a7
@r-sharp
Adding first draft of Sams bdiff object to fcm_bdiff.py
a90c06a
@r-sharp
Adjusting Fortran keyword checking to Sam's improved
9276506 
methodology. Plus making the branch processing of files changes return a list.
@r-sharp
Merge branch 'MetOffice:main' into umdp3_checker_in_python
0c11e7b
@r-sharp
Committing changes so UM rose-stem can extract my versions and use th…
b7a5970 
…em...
@r-sharp
Adding some basic unit tests for the Fortran checkers in umdp3.py
d6260d3
@r-sharp
Adding some more basic unit tests for umdp3
dd7fb83
@r-sharp
Adding a couple more basic unit tests...
f022438
@r-sharp
More unit tests - almost done honest guv...
ddb54af
@r-sharp
Final set of "Fortran" checking unit tests, lus a wee bit O tidying
dde6488
@r-sharp
Some tidying up, some 'moving about' of lists to a separate file for …
00f0fca 
…clarity

and to reduce the size of umdp3.py.
@r-sharp
Adding comments and todos
8149eb1
@r-sharp
Merge branch 'MetOffice:main' into umdp3_checker_in_python
6149bd5
@r-sharp
Adding latest non-working changes to re-write in umdp3_conformance.py
ffb868e
@r-sharp
Trying to get git/github to sync everything - just blindly following
69ec0ed 
hints as at every step it suggests something else...
@r-sharp
Trying to get fcm_bdiff to work like git_bdiff...
8214a0c
@yaswant
Copy link
Collaborator

yaswant commented Jan 20, 2026

over to you @r-sharp

r-sharp and others added 20 commits January 20, 2026 15:06
@r-sharp @yaswant
Update fcm_bdiff/fcm_bdiff.py
b49e1ff 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp @yaswant
Update fcm_bdiff/fcm_bdiff.py
31efcff 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp @yaswant
Update fcm_bdiff/fcm_bdiff.py
3b5cf9a 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp @yaswant
Update fcm_bdiff/fcm_bdiff.py
ebf0444 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp @yaswant
Update fcm_bdiff/fcm_bdiff.py
ca2f839 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp @yaswant
Update fcm_bdiff/fcm_bdiff.py
8632440 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp @yaswant
Update fcm_bdiff/fcm_bdiff.py
a825595 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp @yaswant
Update fcm_bdiff/fcm_bdiff.py
728d6cd 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp @yaswant
Update fcm_bdiff/fcm_bdiff.py
9872554 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp @yaswant
Update fcm_bdiff/fcm_bdiff.py
a5022ac 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp @yaswant
Update script_umdp3_checker/tests/test_umdp3.py
679620f 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp @yaswant
Update script_umdp3_checker/tests/test_umdp3.py
903e963 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp @yaswant
Update script_umdp3_checker/tests/test_umdp3.py
5cdd264 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp @yaswant
Update script_umdp3_checker/search_lists.py
3a85fa4 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp @yaswant
Update script_umdp3_checker/tests/test_umdp3.py
8af530f 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp @yaswant
Update script_umdp3_checker/checker_dispatch_tables.py
0ac48ef 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp @yaswant
Update script_umdp3_checker/tests/test_umdp3.py
e51cd11 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp @yaswant
Update script_umdp3_checker/tests/test_umdp3.py
bb7edf5 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp @yaswant
Update script_umdp3_checker/tests/test_umdp3.py
a923c9b 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp
Merge branch 'main' into umdp3_checker_in_python
0dddf64
r-sharp and others added 5 commits January 20, 2026 16:24
@r-sharp @yaswant
Update fcm_bdiff/fcm_bdiff.py
c89245d 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp @yaswant
Update fcm_bdiff/fcm_bdiff.py
55e50bc 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp @yaswant
Update fcm_bdiff/fcm_bdiff.py
cdda1ac 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp @yaswant
Update fcm_bdiff/fcm_bdiff.py
3c58e32 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@r-sharp @yaswant
Update fcm_bdiff/fcm_bdiff.py
24438b2 
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
@yaswant yaswant merged commit 5f4146c into MetOffice:main Jan 22, 2026
5 checks passed
@jennyhickson jennyhickson added this to the Spring 2026 milestone Jan 29, 2026
@r-sharp r-sharp deleted the umdp3_checker_in_python branch January 29, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaswant yaswant yaswant approved these changes

@jennyhickson jennyhickson jennyhickson approved these changes

Assignees

@r-sharp r-sharp

Labels

CI git-migration

Projects

None yet

Milestone

Spring 2026

Development

Successfully merging this pull request may close these issues.

3 participants

@r-sharp @yaswant @jennyhickson