Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up on #224 - the first commit adds an experimental merge of the serial interrupt handlers (com1 & com2) so that all lines share the same code. This saves some code - and required some
asmhacks still being tested.The following commit removeds the old (slow) serial handler and makes all lines equal, sharing the same driver, inspired by ghaerr/elks#2604.
One important experience while working on merging the interrupt handlers is that
volatiledoesn't always do what one expects, and most of the time does nothing at all. Also, the constructasm volatile ("" ::: "memory");which is supposed to create a 'barrier´ between statements before and after, ensuring that no optimization crosses that line, doesn't have any effect whatsoever.