Conversation
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| # Copy configuration options | ||
| try: | ||
| config = widget.configure() | ||
| except tk.TclError: | ||
| config = {} |
There was a problem hiding this comment.
[P1] Cloned tabs discard widget runtime state
The new _clone_widget instantiates fresh widgets and only replays configuration options and event bindings. Stateful content (text inserted into a Text/Entry without a textvariable, listbox items, canvas drawings, etc.) is stored inside the widget rather than in configure() data, so these values are dropped when the original tab is destroyed and the clone is added. The previous implementation reparented the existing widget and preserved this state. Detaching a tab that users have already interacted with will now silently lose their data.
Useful? React with 👍 / 👎.
Summary
Testing
radon cc -j gui/utils/widget_transfer_manager.pypytest tests/detachment/window/test_reparent_across_toplevel.pypytest(failed: Segmentation fault)https://chatgpt.com/codex/tasks/task_b_68bba11ff6c08327b511e5b78c9ab667