Use Unicode box characters inside strings#152
Merged
Conversation
* Rename/regularize JSON and YAML naming * DRY tests * remove egg stuff from pyproject.toml
Remove unused code.
Corrected spelling errors in comments and docstrings.
It accidentally got deleted in creating ESCAPE_CODES
rocky
force-pushed
the
unicode-box-characters
branch
from
1f95273 to
a985ec6
Compare
rocky
force-pushed
the
unicode-box-characters
branch
from
193a48e to
5a3da9d
Compare
rocky
force-pushed
the
unicode-box-characters
branch
from
f2eebf9 to
9859228
Compare
rocky
force-pushed
the
unicode-box-characters
branch
from
832aa57 to
0d43e46
Compare
rocky
force-pushed
the
unicode-box-characters
branch
3 times, most recently
from
3bd0453 to
8639d83
Compare
rocky
force-pushed
the
unicode-box-characters
branch
11 times, most recently
from
3bd89a9 to
f036273
Compare
rocky
force-pushed
the
unicode-box-characters
branch
from
f036273 to
733fc1b
Compare
rocky
changed the title
we need to track wither we are in a *String*, not whether we are in a box.
Member
Author
|
@mmatera: There is more to small tweaks to do - add some tests of the boxing yaml for consistency, add an examples field, stuff like that. However, this is getting large. I can add that in here or in another PR. Your choice. |
Contributor
|
@rocky, thanks for start tackling this. LGTM |
Member
Author
There will be more rounds.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in Mathics3/mathics-core#1622.
This is needed to make built-in functions
Characters,StringLength,StringTake, andToCharacterCodework when there are Boxing expression escape sequences inside strings.Note that all Unicode characters used fall into the Private Use Area of Unicode that Wolfram uses for its own internal system markers, specifically the range 0xf7c0 to 0xf7cd.
There has also been a slight refactor in the use of table names as we've now grown one more YAML table.