Skip to content

Conversation

@freyazjiner
Copy link
Member

@freyazjiner freyazjiner commented Jan 25, 2026

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
This pull request addresses issue #7729 by updating the MarkUs student view homepage to separate courses into two groups: Current Courses and Past Courses.

Since courses cannot be grouped by semester, the distinction is made by comparing each course’s end_at date with the current date:

  • Courses whose end date is in the future are shown under Current Courses.
  • Courses whose end date is in the past are shown under Past Courses.
  • If a group has no courses, its section title is not rendered.
Screenshots of your changes (if applicable) instructor's view: 377d544da60d031081b71ceb705b18bf student's view with both current courses and past courses: 6b2f70f3ce184e2812c744e033128445 student's view with current courses but no past courses: 5f70ac76c582233993c42dcb54839c43
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality) X
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls
Copy link
Collaborator

coveralls commented Jan 25, 2026

Pull Request Test Coverage Report for Build 21343401390

Details

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 91.651%

Totals Coverage Status
Change from base Build 21339519388: 0.003%
Covered Lines: 44357
Relevant Lines: 47589

💛 - Coveralls

@freyazjiner freyazjiner marked this pull request as draft January 25, 2026 23:22
@freyazjiner freyazjiner marked this pull request as ready for review January 26, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants