Skip to content

Conversation

@donny-wong
Copy link
Contributor

@donny-wong donny-wong commented Jan 23, 2026

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

The roster_sync process ensures that student visibility in MarkUs remains synchronized with Canvas enrollment. Students deactivated or removed in Canvas are automatically hidden in MarkUs, while re-enrolled students are restored to active status.

Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) x
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@donny-wong donny-wong changed the title Hide students for deactivated or missing students during roster sync Hide deactivated/missing students and restore re-enrolled students during roster sync Jan 23, 2026
@donny-wong donny-wong requested review from Naragod and removed request for Naragod January 23, 2026 20:29
course_role = Student.create!(user: markus_user, course: lti_deployment.course)
end
end
next if course_role.nil?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why you changed this, you can keep the next statement

@donny-wong donny-wong added this to the v2.9.1 milestone Jan 26, 2026
@donny-wong donny-wong linked an issue Jan 26, 2026 that may be closed by this pull request
@donny-wong donny-wong force-pushed the roster_sync_inactive_students branch from 85d214e to 101dcfb Compare January 26, 2026 14:40
@coveralls
Copy link
Collaborator

coveralls commented Jan 26, 2026

Pull Request Test Coverage Report for Build 21363397446

Details

  • 57 of 58 (98.28%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 91.657%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/helpers/lti_helper.rb 22 23 95.65%
Totals Coverage Status
Change from base Build 21339519388: 0.009%
Covered Lines: 44379
Relevant Lines: 47611

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Roster Sync to handle removals/dropped students

3 participants