Skip to content

Fix markbind serve regression#2837

Merged
gerteck merged 1 commit intoMarkBind:masterfrom
Harjun751:fix-baseurl-bug
Feb 19, 2026
Merged

Fix markbind serve regression#2837
gerteck merged 1 commit intoMarkBind:masterfrom
Harjun751:fix-baseurl-bug

Conversation

@Harjun751
Copy link
Contributor

@Harjun751 Harjun751 commented Feb 19, 2026

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:

The problem was that a baseUrl defined in the site.json was only working for the entrypoint file - for other files it was mounted as if the baseUrl was not set at all.

Replaced placeholder value passed as parameter during typescript migration that changed behavior of the function with a value that represents how it actually worked before the migration.

Anything you'd like to highlight/discuss:
My bad yall - was careless during migration and this sneaky issue came up. We really need the testing suite for CLI to cover those commands as well 😭

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)

Fix markbind serve regression

When running markbind serve with a defined
baseUrl in the site.json, it only serves
the entrypoint file at the baseUrl while
other sites are served as if baseUrl was not
set.

This is not intentional behaviour.

Fix the regression by removing a placeholder
parameter that was introduced during typescript
migration.


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

When running `markbind serve` with a defined
baseUrl in the site.json, it only serves
the entrypoint file at the baseUrl while
other sites are served as if baseUrl was not
set.

This is not intentional behaviour.

Fix the regression by removing a placeholder
parameter that was introduced during typescript
migration.
@Harjun751 Harjun751 requested a review from a team February 19, 2026 11:19
@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.07%. Comparing base (c8f372e) to head (306f230).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2837    +/-   ##
========================================
  Coverage   72.07%   72.07%            
========================================
  Files         134      134            
  Lines        7410     7410            
  Branches     1528     1649   +121     
========================================
  Hits         5341     5341            
+ Misses       2024     1941    -83     
- Partials       45      128    +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Harjun751 Harjun751 mentioned this pull request Feb 19, 2026
14 tasks
@gerteck
Copy link
Member

gerteck commented Feb 19, 2026

no worries, i did not catch the regression as well in my review, thanks for catching the bug and the quick fix!

So it was only working for the index.html file but not the others? Interesting, the side effect of the change seems very insidious.

@gerteck gerteck merged commit bc56f0a into MarkBind:master Feb 19, 2026
11 checks passed
@github-actions github-actions bot added the r.Patch Version resolver: increment by 0.0.1 label Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r.Patch Version resolver: increment by 0.0.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments