Fix markbind serve regression#2837
Merged
gerteck merged 1 commit intoMarkBind:masterfrom Feb 19, 2026
Merged
Conversation
When running `markbind serve` with a defined baseUrl in the site.json, it only serves the entrypoint file at the baseUrl while other sites are served as if baseUrl was not set. This is not intentional behaviour. Fix the regression by removing a placeholder parameter that was introduced during typescript migration.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2837 +/- ##
========================================
Coverage 72.07% 72.07%
========================================
Files 134 134
Lines 7410 7410
Branches 1528 1649 +121
========================================
Hits 5341 5341
+ Misses 2024 1941 -83
- Partials 45 128 +83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
no worries, i did not catch the regression as well in my review, thanks for catching the bug and the quick fix! So it was only working for the
|
gerteck
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
The problem was that a baseUrl defined in the site.json was only working for the entrypoint file - for other files it was mounted as if the baseUrl was not set at all.
Replaced placeholder value passed as parameter during typescript migration that changed behavior of the function with a value that represents how it actually worked before the migration.
Anything you'd like to highlight/discuss:
My bad yall - was careless during migration and this sneaky issue came up. We really need the testing suite for CLI to cover those commands as well 😭
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Fix
markbind serveregressionWhen running
markbind servewith a definedbaseUrl in the site.json, it only serves
the entrypoint file at the baseUrl while
other sites are served as if baseUrl was not
set.
This is not intentional behaviour.
Fix the regression by removing a placeholder
parameter that was introduced during typescript
migration.
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major,r.Minor,r.Patch.Breaking change release note preparation (if applicable):