Fix fault dip display: retrieve from shapefile data instead of normal vector#83
Merged
lachlangrose merged 4 commits intomainfrom Feb 19, 2026
Merged
Conversation
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>
Co-authored-by: lachlangrose <7371904+lachlangrose@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix fault dip not displayed properly in Geological Features panel
Fix fault dip display: retrieve from shapefile data instead of normal vector
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fault dip values from shapefiles were always displayed as 90° in the Geological Features panel instead of showing the actual shapefile values.
Changes
FaultFeatureDetailsPanel.__init__()to retrieve dip and pitch frommodel_manager.faults[fault.name]['data'](where shapefile values are stored) before falling back to normal vector calculationTechnical Details
Previous implementation:
New implementation retrieves from stored data:
The fault normal vector may not reflect the original shapefile dip value, causing the mismatch. This change preserves the original data from
update_fault_points()where shapefile fields are mapped to fault data columns.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.