Open
Conversation
Owner
|
JSPteroAPI/src/client/methods/console.ts Line 14 in 225aa51 Wouldn't it be easier to just make this a public function and write up the docs for it? |
Author
|
Ahh yeah I suppose so, I can't lie I didn't even see that |
Owner
|
So please do that and otherwise it's all good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know you already have the startConsoleConnection function, I just needed this to return the URL and the token. Let me know if there is anything else to change as I haven't looked too deeply into it.