Conversation
Add an abstarct DriveCurve class and a concrete ExproDriveCurve class, both based on LemLib's implementation.
Allow users to assign a DriveCurve per axis to be used by the controller when updating joystick values.
…/joystick-enhancements
SizzinSeal
requested changes
Nov 4, 2024
Member
SizzinSeal
left a comment
There was a problem hiding this comment.
lgtm from a design standpoint, but it needs more docs as well as some other nitpickings
SizzinSeal
approved these changes
Nov 17, 2024
Member
|
Test data: |
(Note: Fisheye is still broken)
Member
|
More tests: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add controller deadband, curves and fisheye, also changes the const references to Button/floats into getter methods, and renames some stuff.
Test code:
Download the template for this pull request:
Note
This is auto generated from
Add Template to Pull Request