Open
Conversation
|
🚀 Draft Preview: https://pr184-draft.lc0.org/ |
|
🚀 Draft Preview: https://pr184-draft.lc0.org/ |
Contributor
|
Thanks for the update! One very minor comment: I agree with greying out the challenge button in a position which isn't accepted, but I'm less sure about putting the same behavior on the "copy the challenge link". I can see how this tool might be more useful in general for other devs who would like to experiment with their own bots, or play/analyze locally. Obviously copying the challenge link isn't useful for that, but copying the starting FEN could certainly be useful even if it is a position not accepted by our bots. |
|
🚀 Draft Preview: https://pr184-draft.lc0.org/ |
Author
|
🚀 Draft Preview: https://pr184-draft.lc0.org/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

As discussed on Discord https://discord.com/channels/425419482568196106/1393640639274422352/1442836041731018813, the idea is to simplify the workflow for people who want to play multiple games. They select all the options they want and with one click can open the lichess challenge. Without being sure, I am assuming that this should improve the experience of the players a little bit, but also providing slightly less information to the developer/user (such as the exact random id and fen string, although that string is also displayed on lichess). I also changed the string for FRC random generation from "Auto" to "Random" to make that clearer.