-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Use vcpkg for MinGW dependencies #8218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
messmerd
wants to merge
45
commits into
LMMS:master
Choose a base branch
from
messmerd:mingw-vcpkg-testing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+205
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update install-powershell.sh script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finally switches most of the MinGW build's dependencies from tobydox's PPA to vcpkg.
Since the tobydox PPA was created for Ubuntu 20.04 (focal), its dependencies were several years out-of-date. But now with vcpkg, we have the latest versions of our dependencies, finally enabling LV2 plugins, mp3/opus support, and per-note panning in Sf2 Player.
There are some exceptions however:
For these exceptions, I'm continuing to use the tobydox PPA for now, but in a follow-up PR, I'd like to fully remove our dependence on the PPA.
Also, suil is neither available on the tobydox PPA nor vcpkg yet, so we will need to add that to vcpkg in the future.
TODO:
Closes #6871