Python bindings using scikit build core#316
Draft
hendrikmuhs wants to merge 79 commits intoKeyviDev:masterfrom
Draft
Python bindings using scikit build core#316hendrikmuhs wants to merge 79 commits intoKeyviDev:masterfrom
hendrikmuhs wants to merge 79 commits intoKeyviDev:masterfrom
Conversation
hendrikmuhs
force-pushed
the
scikit-buildcore
branch
from
4d7cd61 to
3e0fe58
Compare
hendrikmuhs
force-pushed
the
scikit-buildcore
branch
from
3e0fe58 to
2bf9bf0
Compare
add CI for pybind wrapper use macos-14 runner update tag disable macos-14 remove integration tests skip pp37 adapt sdist fix style fix style revert cibuildwheel changes try to fix sdist move keyvi source out of src install pytest add more match bindings move module import switch to scikit_build remove license file
hendrikmuhs
force-pushed
the
scikit-buildcore
branch
from
1b1997a to
f9cd3dd
Compare
This reverts commit dd1af35.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
keyvi/include/keyvi/dictionary/completion/forward_backward_completion.h
Outdated
Show resolved
Hide resolved
keyvi/include/keyvi/dictionary/completion/forward_backward_completion.h
Outdated
Show resolved
Hide resolved
keyvi/include/keyvi/dictionary/completion/forward_backward_completion.h
Outdated
Show resolved
Hide resolved
keyvi/include/keyvi/dictionary/completion/forward_backward_completion.h
Outdated
Show resolved
Hide resolved
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#310 follow up
further investigate options to renovate the python bindings using scikit build core. Scikit build core is a wrapper on top of pybind11 (but also offers other options). With scikit build core we don't need to maintain a pybind subtree.