Skip to content

fix: improve error messaging for agent output validation failures #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mr-Neutr0n wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: improve error messaging for agent output validation failures #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/ai/claude-executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,15 @@ export async function validateAgentOutput(
console.log(chalk.green(` Validation passed: Required files/structure present`));
} else {
console.log(chalk.red(` Validation failed: Missing required deliverable files`));
// Log which file is expected for common agents to help with debugging
const expectedFiles: Record<string, string> = {
'pre-recon': 'deliverables/code_analysis_deliverable.md',
'recon': 'deliverables/recon_deliverable.md',
'report': 'deliverables/comprehensive_security_assessment_report.md',
};
if (agentName && expectedFiles[agentName]) {
console.log(chalk.yellow(` Expected file: ${sourceDir}/${expectedFiles[agentName]}`));
}
}

return validationResult;
Expand Down
12 changes: 11 additions & 1 deletion src/temporal/activities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,8 +229,18 @@ async function runAgentActivity(

// Limit output validation retries (unlikely to self-heal)
if (attemptNumber >= MAX_OUTPUT_VALIDATION_RETRIES) {
// Build helpful troubleshooting message
const troubleshootingTips = agentName === 'pre-recon'
? `\n\nTroubleshooting tips:
1. Check if the repository path is accessible: ${repoPath}
2. If using ROUTER mode, ensure the model supports tool use and follows instructions well
3. Check agent logs at: audit-logs/*/agents/${agentName}*.jsonl
4. Try running with a different model (Claude models recommended)
5. Ensure the target URL is reachable from the Docker container`
: '';

throw ApplicationFailure.nonRetryable(
`Agent ${agentName} failed output validation after ${attemptNumber} attempts`,
`Agent ${agentName} failed output validation after ${attemptNumber} attempts. Required deliverable files were not created.${troubleshootingTips}`,
'OutputValidationError',
[{ agentName, attemptNumber, elapsed: Date.now() - startTime }]
);
Expand Down