-
Notifications
You must be signed in to change notification settings - Fork 0
feat: реализован UI для билета #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dianakuprava
wants to merge
12
commits into
dev
Choose a base branch
from
FELL02-8
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seva123321
reviewed
Jul 27, 2025
Elvira-Elshina
previously approved these changes
Jul 28, 2025
Elvira-Elshina
previously approved these changes
Aug 1, 2025
Collaborator
Elvira-Elshina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
В целом всё супер, но для dev-а лучше всё же добавить билет в какой-нибудь роут, но это Леонид уже скажет
TatianaKuzArt
previously approved these changes
Aug 1, 2025
0ad3f90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ПРАВКИ 2:
Она возвращает корректное окончание в зависимости от числа: "место" | "места" | "мест".
содержащий общий интерфейс
Добавлены компоненты TicketCard, TicketHeader, TariffsSection, RouteInfo и др.
Иконки вынесены в shared/ui/icons
Реализованы стили и структура билета
Правки:
Разделение TariffsSection на переиспользуемые компоненты:
-Вынесены карточки тарифов в отдельный компонент TariffCard
Исправление форматирования цен:
-Заменены все toLocaleString('ru-RU') на Intl.NumberFormat('ru-RU')
Оптимизация работы с тенями:
-Вынесена тень в константу shadowClass
-Устранено дублирование кода
Улучшения типизации:
-Явные интерфейсы пропсов для всех компонентов
Оптимизация структуры
-Реализованы barrel-экспорты (index.ts) для каждого компонента
-Оптимизированы импорты (абсолютные пути вместо относительных)
-Соответствие FSD
Добавила слово return перед разметкой