Add context version of main functions#17
Open
a-urth wants to merge 5 commits intoJustinTimperio:masterfrom
Open
Add context version of main functions#17a-urth wants to merge 5 commits intoJustinTimperio:masterfrom
a-urth wants to merge 5 commits intoJustinTimperio:masterfrom
Conversation
Author
|
It looks like codacy is running still on first commit and gives error disregard that issue is fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: since main scanning functions use goroutines there is no way to stop them externally if used as library.
Solution: add new function which accept content as first parameters. In main loops of goroutines check for context in select statement and shutdown in case it closed.