Support UUID and other stringlike types as keys#435
Open
treapster wants to merge 1 commit intoJuliaIO:masterfrom
Open
Support UUID and other stringlike types as keys#435treapster wants to merge 1 commit intoJuliaIO:masterfrom
treapster wants to merge 1 commit intoJuliaIO:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #435 +/- ##
=======================================
Coverage 90.26% 90.26%
=======================================
Files 7 7
Lines 1366 1366
=======================================
Hits 1233 1233
Misses 133 133 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following error with UUID and other types:
The same error happens with Char, VersionNumber and some other types which should work out of the box.
For
lowerkeyI also changedUnion{Float16, Float32, Float64}toReal, but if there is a reason why only specific types were supported we can revert it.