Don't defer input evaluation to REPL backend#376
Merged
KristofferC merged 2 commits intoJuliaDebug:masterfrom Jun 5, 2025
Merged
Don't defer input evaluation to REPL backend#376KristofferC merged 2 commits intoJuliaDebug:masterfrom
KristofferC merged 2 commits intoJuliaDebug:masterfrom
Conversation
Contributor
|
Can this have a test added to make sure this doesn't regress in the future? |
oscardssmith
approved these changes
Jun 5, 2025
Contributor
Author
Contributor
Author
|
#308 was an attempt to fix these tests but it seems efforts have been abandoned since. |
Contributor
|
@KristofferC can you approve CI? |
|
Nice! Thank you for attending to this. Can confirm that this works for me locally 🥳 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #376 +/- ##
==========================================
- Coverage 51.03% 50.82% -0.22%
==========================================
Files 9 9
Lines 821 850 +29
==========================================
+ Hits 419 432 +13
- Misses 402 418 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Tests need to be updated for nightly and this is not tested anyway. |
Contributor
Author
|
Thanks @KristofferC! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #373.
The fix implemented in #367 spawned a new task for the evaluation, but this eventually synchronized with the backend too (through a backend
Channel), still causing a deadlock (or at least, in certain circumstances).This was largely inspired from JuliaDebug/Infiltrator.jl#139, which sidesteps backend synchronization entirely.