Open
Conversation
Roughly 2x faster by removing the need to store closures
Codecov ReportBase: 99.45% // Head: 99.74% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
==========================================
+ Coverage 99.45% 99.74% +0.29%
==========================================
Files 15 16 +1
Lines 3507 3585 +78
==========================================
+ Hits 3488 3576 +88
+ Misses 19 9 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roughly 2x faster by removing the need to store closures. Maybe there's more that can be done here.
I also tried doing similar changes to equality, but this would require evaluating all key paths for equality, or
KeyPath<Root, some Hashable>to be compatible with e.g.KeyPath<Root, String>.