Matrix Minors and Cofactors Convenience Methods #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…entation The adjugate matrix is the transpose of the cofactor matrix, not just the transpose of the original matrix. Updated getAdjugate() to use cofactors()->getAdjoint() to correctly compute the adjugate. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Added comprehensive tests for the minors() method covering: - 2x2 matrices - 3x3 matrices - 1x1 matrices (edge case) The tests verify that minors() correctly returns the matrix of minors for each element, following existing test patterns. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement minors and cofactors methods for the Matrix class to complete linear algebra capabilities. This addresses an existing TODO in the codebase and is required for more advanced matrix operations.