fix type error in queue.hpp, improve distributability and documentation#10
Open
keyan3 wants to merge 39 commits intoJimmy-Lin:masterfrom
Open
fix type error in queue.hpp, improve distributability and documentation#10keyan3 wants to merge 39 commits intoJimmy-Lin:masterfrom
keyan3 wants to merge 39 commits intoJimmy-Lin:masterfrom
Conversation
first draft based on examples
build for x86 mac and linux with cibuildwheel + GH actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code changes:
queue.hppthat allows gosdt c++ code to compile on clang with versions oftbbafter '2020_U3' (solves this issue i opened previously)Distribution:
gosdtc++ extension doesn't need to be built on every users machine. This also prevents users from having to install the dependencies liketbb, etc.requirements.txtthat makes installing the dependencies for the local python wrapper easierDocumentation:
setup.pyfor users who installgosdtviapip(keptjimmy.projects.linas contact email, let me know if this should be updated)let me know if you have any questions or concerns!