Skip to content

Conversation

@ahmadazimi
Copy link
Contributor

var keyword was not placed before FontDetect statement, so in use strict mode you have an error.

@JenniferSimonds
Copy link
Owner

Good catch, thanks! But I'll need you to make 2 changes before I can merge this:

  1. Please submit the pull request to Stage 3.0.2 instead of Master. Once a version is ready to be released, I merge the current Stage into Master. This keeps Master clean while changes or bugfixes are still under development.
  2. Don't bother including fontdetect.min.js - I'll minify fontdetect.js when it's ready to release.

@ahmadazimi
Copy link
Contributor Author

I've created a new pull request. I hope I've done it correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants